New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat tagged templates as function calls #389

Merged

ryansolid merged 1 commit into ryansolid:main from edemaine:tagged-template-literals

Dec 10, 2024

+6 −1

Contributor

edemaine commented Dec 9, 2024

Fixes solidjs/solid#2377

Without the change, the test compiles to the incorrect

const singleTemplateLiteral = greeting`world`


          Treat tagged templates as function calls

6a23046

Fixes solidjs/solid#2377

edemaine mentioned this pull request

Tagged template function doesn't trigger rerender solidjs/solid#2377

Closed

ryansolid merged commit 828f9e9 into ryansolid:main

2 checks passed

Owner

ryansolid commented Dec 10, 2024

Awesome thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet